Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Modifying a layout does not rebuild in watch mode #362
When I run Sculpin with
That sounds unusual. I'm not sure why it would trigger a new build without actually building from the new template content. I'll see if I can reproduce the issue tonight.
Out of curiosity, is the template you're modifying being directly referenced in the front matter of your content?
Also, does the template being modified extend from a different template file using the Twig
(I also am curious which OS and PHP version sculpin is being run on, as that may help with replicating the issue)
Sorry for the missing details. I have Windows 10 and PHP 7.1.14, running in Git-Bash.
OK, so I was able to replicate the issue on Develop - but not on Master. Master seemed to work fine.
This barebones composer.json is able to install Sculpin 2.1.1 (which is pretty close to master):
Those two packages need to be interpreted at the same time by composer, or else they will start fighting over which version of
I'm hoping to remove the embedded-composer dependency sometime soon, it seems to be quite troublesome due to this conflict.
referenced this issue
Feb 21, 2018
The cause of this appears to be that the develop branch is using Twig V2, which has changed the way templates are cached. I've opened a PR that attempts to fix the issue, but it requires extra eyes just in case I've missed a safer or more future-proof way to fix things.
Thanks for filing the report, by the way. Hoping to get this resolved very soon.