Add 'env' as a default variable available via {{ site.env }} in Twig templates #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…templates. The environment is available while pulling in config files so this change adds the environment to the 'site' variable. I've tried to avoid code duplication by adding the getConfigFile() method, but I'm not totally happy with the if .. elseif .. else block.
|
@Stubbs Thanks! I'd like to get another set of eyes on this before we merge it. This exposes it by way of |
|
Correct. |
|
Not sure why the coverage is so low for 5.3.3? That's what's caused the failure above. |
|
@Stubbs I'm not worried about that right now. Code coverage for Sculpin is slow anyway and we'll fix that at another time. But thanks for looking into the Travis CI failure. I appreciate it! |
|
Agree that structure is a bit messy, but not worth sweating over 👍 |
|
Made a small PR on your PR regarding the structure: Stubbs#1 👍 on exposing the environment through |
Changed the way a configuration file is detected.
|
👍 @WyriHaximus I like that, I've merged it in to my pull request. |
|
👍 👍 |
simensen
added a commit
that referenced
this pull request
Jan 29, 2015
Add 'env' as a default variable available via {{ site.env }} in Twig templates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The environment is available while pulling in config files so this change
adds the environment to the 'site' variable.
I've tried to avoid code duplication by adding the getConfigFile() method,
but I'm not totally happy with the if .. elseif .. else block.