Make sure that all twig files end up as .html files.

[naxoc]

A simple - maybe too simple - solution to the problem in #172

[simensen]

@naxoc FWIW, I haven't forgotten about this. I thought I had responded at least, though. My bad.

I think this solution may indeed be too simple. I think it might work but I think I'd rather have this happening elsewhere. I need to think on it some. :)

[ibrasho]

I think this should be implemented in Sculpin\Core\Permalink\SourcePermalinkFactory. Most probably in SourcePermalinkFactory::generatePermalinkPathname().

Just ensure that the filename extension is .html.

@simensen What do you think?

[simensen]

@ibrasho That sounds reasonable. It is closer to what I had in mind. Probably right after $pathname = $source->relativePathname(); is called, we could run this code to remove the .twig bit from the pathname. I'm still not super happy about this, but that is mostly because SourcePermalinkFactory is a bad implementation anyway. :)

@naxoc How do you feel about moving this around to where @ibrasho suggested?

[naxoc]

That sounds good to me. I'll give it a go in the weekend :)

[naxoc]

Still super simple - but in a place it makes much more sense now.

[simensen]

Thanks!