New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dropping support for PHP 5.3 and PHP 5.3.3 #208
Conversation
|
doesn't react already force a php 5.4 requirement ? |
|
@jrobeson No, it doesn't: https://github.com/reactphp/http/blob/v0.2.0/composer.json. |
|
ah, not 0.2.0 |
|
The Sculpin Roadmap specifically states that Sculpin will continue to support 5.3.2 in Sculpin 2, and then Sculpin 3 will be based on PHP7. I still support bumping Sculpin 2 to PHP 5.4, but I can see the reasons not to. If we don't bump it, I will likely rewrite PR #207 as an extension instead of a built-in feature. |
|
@beryllium I'm not opposed to considering bumping Sculpin to 5.4 for Sculpin 2. The blog post was may be too specific on the 5.3.3+ support. :) I haven't looked at #207 close enough yet, but I'll get to making a comment on there now. |
|
Bumping makes sense especially in the sculpin use case. We're not talking about legacy shared hosts that don't update their PHP. As far as I know that's the primary reason to support EOL'd versions. I think we're in a pretty safe space on this one as users do most of the PHP execution on their local machines and port static content to any non-php server. |
|
Any updates? |
|
FYI the Travis builds started failing on 5.3.3: |
PHP 5.3 became an EOL unsupported branch in August of 2014. We should consider removing support for it from Sculpin, as well.
Continuing to support PHP 5.3 also means that I can't use my preferred choice of image manipulation library for PR #207.