Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropping support for PHP 5.3 and PHP 5.3.3 #208

Closed
wants to merge 3 commits into from

Conversation

beryllium
Copy link
Member

PHP 5.3 became an EOL unsupported branch in August of 2014. We should consider removing support for it from Sculpin, as well.

Continuing to support PHP 5.3 also means that I can't use my preferred choice of image manipulation library for PR #207.

@ghost
Copy link

ghost commented Mar 1, 2015

doesn't react already force a php 5.4 requirement ?

@GrahamCampbell
Copy link

@jrobeson No, it doesn't: https://github.com/reactphp/http/blob/v0.2.0/composer.json.

@ghost
Copy link

ghost commented Mar 1, 2015

ah, not 0.2.0

@beryllium
Copy link
Member Author

The Sculpin Roadmap specifically states that Sculpin will continue to support 5.3.2 in Sculpin 2, and then Sculpin 3 will be based on PHP7.

I still support bumping Sculpin 2 to PHP 5.4, but I can see the reasons not to. If we don't bump it, I will likely rewrite PR #207 as an extension instead of a built-in feature.

@simensen
Copy link
Member

simensen commented Mar 2, 2015

@beryllium I'm not opposed to considering bumping Sculpin to 5.4 for Sculpin 2. The blog post was may be too specific on the 5.3.3+ support. :) I haven't looked at #207 close enough yet, but I'll get to making a comment on there now.

@Incognito
Copy link

Bumping makes sense especially in the sculpin use case. We're not talking about legacy shared hosts that don't update their PHP. As far as I know that's the primary reason to support EOL'd versions. I think we're in a pretty safe space on this one as users do most of the PHP execution on their local machines and port static content to any non-php server.

@TomasVotruba
Copy link

Any updates?

@davereid
Copy link
Contributor

FYI the Travis builds started failing on 5.3.3:

$ composer --prefer-source install
Warning: This development build of composer is over 30 days old. It is recommended to update it by running "/home/travis/.phpenv/versions/5.3.3/bin/composer self-update" to get the latest version.
Loading composer repositories with package information
Installing dependencies (including require-dev) from lock file
Your requirements could not be resolved to an installable set of packages.
  Problem 1
    - Installation request for symfony/http-foundation v2.7.0 -> satisfiable by symfony/http-foundation[v2.7.0].
    - symfony/http-foundation v2.7.0 requires php >=5.3.9 -> no matching package found.
  Problem 2
    - symfony/http-foundation v2.7.0 requires php >=5.3.9 -> no matching package found.
    - symfony/http-kernel v2.3.4 requires symfony/http-foundation ~2.2 -> satisfiable by symfony/http-foundation[v2.7.0].
    - Installation request for symfony/http-kernel v2.3.4 -> satisfiable by symfony/http-kernel[v2.3.4].
Potential causes:
 - A typo in the package name
 - The package is not available in a stable-enough version according to your minimum-stability setting
   see <https://groups.google.com/d/topic/composer-dev/_g3ASeIFlrc/discussion> for more details.
Read <http://getcomposer.org/doc/articles/troubleshooting.md> for further common problems.
The command "composer --prefer-source install" failed and exited with 2 during .

@davereid davereid mentioned this pull request Jul 31, 2015
@simensen simensen closed this in 0d7af13 Jul 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants