Require at least Symfony LTS versions #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've no objections to this 👍 |
|
@jrobeson Would you mind rebasing this PR so that we can merge it? |
As far as i can tell, the subcomponent versions weren't in line with the versions set in the main composer.json. If you were to install the subcomponents separately you'd be using totally unmaintained (and likely untested against) versions of the symfony components.
|
done. |
simensen
added a commit
that referenced
this pull request
Apr 22, 2015
Require at least Symfony LTS versions
|
thanks! |
simensen
added a commit
to simensen/sculpin
that referenced
this pull request
Jun 7, 2015
davedevelopment
added a commit
that referenced
this pull request
Jun 7, 2015
Updated lock file (re: #212)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as i can tell, the subcomponent versions weren't
in line with the versions set in the main composer.json.
If you were to install the subcomponents separately you'd be using
totally unmaintained (and likely untested against) versions of
the symfony components.