New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a clean option to the generate command. #263
Conversation
|
Good idea! 👍 Does it need any safety checking on the docroot before it goes and deletes stuff, or can we be reasonably sure that it's not going to wipe out / or ~/? :) |
|
I also debated just having this as a separate command too. Hrm, I'm not sure about sanity checking. I would assume that the |
|
I think it makes more sense as a parameter than a separate command. You can always just delete output_* by hand, but you'll often forget to do that on generate - if you've renamed any posts or pages or whatnot, this parameter can save you from the resulting cruft. Also, it will help simplify people's publishing scripts. |
|
👍 for a simple check on the output_dir, even if it's printing the dir to screen with a Y/N input prompt just to be sure |
|
I'd need a way to bypass the input prompt for my deployment workflow, so I'm a little at a loss for what checking I should put in. |
|
I guess maybe adding a new --force parameter that would bypass the input prompt? |
|
👍 for prompt + a way to bypass. I think there is already a non-interactive flag built into symfony console? Maybe we can use that? I think that is just supposed to accept defaults if defaults are allowed, right? |
|
Ah, I see it now, --no-interaction |
|
Ok, will work on the prompt. |
ace9dd7
to
064eff6
Compare
|
Ok I think this is ready again for review, with the added question for confirmation if the --no-interaction flag is not used. I tested this myself with a manually built sculpin.phar. |
|
👍 from me, works all good. |
064eff6
to
eae597e
Compare
|
Is there anything I can do to help this along? Anything missing? Does it need tests? |
Adds a clean option to the generate command.
|
@davereid nope, people have had enough time to object now, merged. |
I thought it would be good if there was an option to clear the output directory out first prior to generation.