New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bumped react/http up to 0.4 from 0.2 #296
Conversation
|
@WyriHaximus Would it be possible to do this with just the react updates and not updating so many other dependencies? I'm 👍 on this but don't want to change things around too much if we can help it. |
|
What do you mean exactly? This purely bumps the |
|
Ah I see what you mean, that's interesting as I only did a |
|
This is going to be messy to fix. The old lock file references a repo (DependencyInjection) that doesn't exist at that url any more. Also both lock files were generated using different versions of composer so it could be that @WyriHaximus is using a more up to date version that requires more recent components. Looking at the latest composer.json in composer itself the components that are being updated are because @WyriHaximus version of composer requires them to be updated. @simensen if you update your composer do you see similar results? |
|
Sorry if this is a stupid question but why is composer required in composer.json in the first place? |
|
@mikebell You're on to something, after making this PR I've ran into an issue with a recent composer update that is steering up troubles when the project (for example) is 5.3+ but you're using 5.5. Will investigate. |
|
What exactly needs to be done here? If it's bumping the version too much |
|
@WyriHaximus Would you mind taking a look at this to see if we should still do this? We can get help resolving the conflict if that helps, but would be good to know if we should actually do this or not. |
|
@WyriHaximus can we bump it to 0.5? |
|
@Xerkus Would love that, but due to up coming |
|
I'm going to close this for now, then. |
|
👍 , I'll either file a new PR or update this PR when |
API didn't change for our use and the lib plus dependencies received several bug fixes including one that causes 100% CPU usage as described in #295. Another thing is that this opens the door to react/filesystem in a later stage for the webservers file IO.