Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumped react/http up to 0.4 from 0.2 #296

Closed

Conversation

WyriHaximus
Copy link
Member

API didn't change for our use and the lib plus dependencies received several bug fixes including one that causes 100% CPU usage as described in #295. Another thing is that this opens the door to react/filesystem in a later stage for the webservers file IO.

@simensen
Copy link
Member

@WyriHaximus Would it be possible to do this with just the react updates and not updating so many other dependencies? I'm 👍 on this but don't want to change things around too much if we can help it.

@WyriHaximus
Copy link
Member Author

What do you mean exactly? This purely bumps the react/http version nothing more. Anything else is just speculation of what we could do 😄 .

@WyriHaximus
Copy link
Member Author

Ah I see what you mean, that's interesting as I only did a composer update react/http and only the reactphp packages got updated :/...

@mikebell
Copy link

This is going to be messy to fix.

The old lock file references a repo (DependencyInjection) that doesn't exist at that url any more. Also both lock files were generated using different versions of composer so it could be that @WyriHaximus is using a more up to date version that requires more recent components.

Looking at the latest composer.json in composer itself the components that are being updated are because @WyriHaximus version of composer requires them to be updated. @simensen if you update your composer do you see similar results?

@mikebell
Copy link

Sorry if this is a stupid question but why is composer required in composer.json in the first place?

@WyriHaximus
Copy link
Member Author

@mikebell You're on to something, after making this PR I've ran into an issue with a recent composer update that is steering up troubles when the project (for example) is 5.3+ but you're using 5.5. Will investigate.

@TomasVotruba
Copy link

What exactly needs to be done here?

If it's bumping the version too much ^0.2 should keep it low and allow higher.

@simensen
Copy link
Member

@WyriHaximus Would you mind taking a look at this to see if we should still do this? We can get help resolving the conflict if that helps, but would be good to know if we should actually do this or not.

@Xerkus
Copy link
Member

Xerkus commented Feb 27, 2017

@WyriHaximus can we bump it to 0.5?

@Xerkus Xerkus added the awaiting author updates Additional information is required label Feb 27, 2017
@WyriHaximus
Copy link
Member Author

@Xerkus Would love that, but due to up coming 0.6, 0.7, 0.8, and eventually 1.0 I would prefer waiting two months before picking this up again

@simensen
Copy link
Member

I'm going to close this for now, then.

@simensen simensen closed this Feb 27, 2017
@WyriHaximus
Copy link
Member Author

WyriHaximus commented Feb 27, 2017

👍 , I'll either file a new PR or update this PR when 1.0 is out 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting author updates Additional information is required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants