Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve travis setup, upgrade phpunit and add php_codesniffer #329

Merged
merged 6 commits into from Mar 1, 2017
Merged

Improve travis setup, upgrade phpunit and add php_codesniffer #329

merged 6 commits into from Mar 1, 2017

Conversation

Xerkus
Copy link
Member

@Xerkus Xerkus commented Mar 1, 2017 •
edited

  • Travis is updated to run tests with lowest/composer.lock/latest dependencies
  • PHP_Codesniffer added with PSR-2 ruleset
  • Phpunit bumped to 4.8.x, the last one supporting PHP 5.4

Includes/depends on #328

@Xerkus
Update dependencies
841e5f1 
- Update sculpin-theme-composer-plugin to stable
- Remove direct dependency on guzzle (indirect remains via react/http)
- Update composer lock file
@Xerkus
Add CS tool with PSR-2 rules
9715875
@Xerkus Xerkus force-pushed the feature/code-quality-tools branch from 1104be8 to b14a023 Compare March 1, 2017 05:22
@Xerkus
Update travis build
09a01ff 
- Run with lowest/locked/latest dependencies
- Run PHP_Codesniffer checks
@Xerkus
Bump phpunit version
b371d9f 
Last phpunit version to support PHP 5.4.x was 4.8
@Xerkus
Do not test locked deps for unmaintained php versions
e13f32d
@Xerkus Xerkus force-pushed the feature/code-quality-tools branch from b14a023 to e13f32d Compare March 1, 2017 05:53
@beryllium
Copy link
Member

👍

Curious if there's a clearer way to indicate that we want "the latest stable 1.x twig" in the composer.json, since saying 1.11 but fetching 1.32 is a bit odd. Not a blocker, though.

@Xerkus
Copy link
Member Author

Xerkus commented Mar 1, 2017 •
edited

Well, ^1.11 means exactly that: we want latest stable in 1.* but not lower than 1.11, it also means that sculpin is declaring its compatibility with everything in that range.
Sculpin is using interface that was introduced in 1.11, hence the bump of the minimum version

@beryllium
Copy link
Member

Oh, I see. So ~1.11 and ^1.11 and ^1.11.0 are basically equivalent.

I shall have to remember this very handy tool: https://semver.mwl.be/#?package=twig%2Ftwig&version=~1.11&minimum-stability=stable

@Xerkus
Copy link
Member Author

Xerkus commented Mar 1, 2017

Yeah, ^ is always about minor version, except for 0.x, and ~ is about lowest specified.
https://getcomposer.org/doc/articles/versions.md describes it

@Xerkus
Copy link
Member Author

Xerkus commented Mar 1, 2017

@beryllium i am not supposed to review and merge my own PRs. In coming days i expect to open quite a few of those. It would be nice if you or other maintainers could review them for me.

@davedevelopment davedevelopment merged commit b5dd7a0 into sculpin:master Mar 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Xerkus @beryllium @davedevelopment