Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental support for relative_root_url #80

Merged
merged 1 commit into from Feb 16, 2015

Conversation

simensen
Copy link
Member

@simensen simensen commented Oct 8, 2013

From @asm89; references balrog support for $relativeUrl. Idea being that you don't want to have the full site URL in every link.

Refs #47

From @asm89; references balrog support for `$relativeUrl`. Idea being that you
don't want to have the full site URL in every link.

Refs sculpin#47
@gnutix
Copy link

gnutix commented Feb 22, 2014

@simensen Any news about that ?

@jmikola
Copy link

jmikola commented Apr 14, 2014

I assume this is only relevant if Sculpin's controller is being served out of a sub-directory? I simply stopped including site_url in my links and have been relying on the relative paths of each content item, which tend to start with a /.

@WyriHaximus
Copy link
Member

👍 look good to me, also relative_root_url > root_relative_url because it's explicit about it's purpose.

@davedevelopment
Copy link
Contributor

👍

simensen added a commit that referenced this pull request Feb 16, 2015
Experimental support for `root_relative_url`
@simensen simensen merged commit fff976a into sculpin:master Feb 16, 2015
@simensen simensen changed the title Experimental support for root_relative_url Experimental support for relative_root_url Feb 16, 2015
@simensen
Copy link
Member Author

It is important to note that I changed the title from root_relative_url to relative_root_url in order to make the title reflect the reality of the code that was actually merged.

@simensen simensen deleted the relative_root_url branch April 21, 2015 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants