Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONFIGURE: Add an environemt variable that discards the --host option #30

Draft
wants to merge 1 commit into
base: master
from

Conversation

@chkr-private
Copy link

@chkr-private chkr-private commented Oct 18, 2020

Backported (and slightly modified) commit scummvm/scummvm@8c28a2d to
be used in scummvm-tools.

Original pull request: scummvm/scummvm#2079.

Backported (and modified) commit scummvm/scummvm@8c28a2d to
be used in scummvm-tools.

In commit 7a68e70 the configure script was modified to silently
ignore some options, that are not needed for scummvm-tools, but are valid
for the configure script generated by GNU Autotools, so the configure
macro for RPM-based distributions can be used when building a rpm
package for them.

Unfortunately the configure script, as used by scummvm-tools uses the --host
option to determine the target system it will actually be build for.
Autotools based configure scripts have a --target option for such a
purpose, and use the --host option to determine the system the build
is performed on.

For that reason there should be a way to discard the parameters passed
to the configure script with the --host option.  The easiest approach
to achieve this goal, is to have an environment variable, which when
set influences the configure script to ignore the parameters of the
--host option.

Thus we introduced a variable called 'CONFIGURE_NO_HOST', that will
when set to anything, but an empty value, before invoking the configure
script, have the parameters of the --host option take no influence on
the configure stage (and the build stage as well).
@sev-
Copy link
Member

@sev- sev- commented Oct 18, 2020

Looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.