From 18193d170e37e0744ad0a9dfe6beed0e2238f9bd Mon Sep 17 00:00:00 2001 From: Johannes Schickel Date: Sun, 15 May 2016 15:48:17 +0200 Subject: [PATCH] Revert "KYRA: Plug memory leak" This reverts commit 9909cc615d527bc8d43f930d8c88dc014974f2de. This will likely cause invalid memory reads because it frees the last output buffer which is used to keep files in memory. There is a possible memory leak here, when the input data is not well formed. However, fixing this takes some more effort than the solution in the reverted commit. --- engines/kyra/resource_intern.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/engines/kyra/resource_intern.cpp b/engines/kyra/resource_intern.cpp index 75e98d320374..9ec955477f2d 100644 --- a/engines/kyra/resource_intern.cpp +++ b/engines/kyra/resource_intern.cpp @@ -1180,8 +1180,6 @@ Common::Archive *InstallerLoader::load(Resource *owner, const Common::String &fi delete tmpFile; tmpFile = 0; } - delete[] outbuffer; - outbuffer = 0; } archives.clear();