From 6e3510ac6154783a99b58bfae83c86145954435f Mon Sep 17 00:00:00 2001 From: Willem Jan Palenstijn Date: Tue, 18 Jun 2013 18:46:54 +0200 Subject: [PATCH] SCI: Add note about LSL1vga DoSoundSendMidi --- engines/sci/sound/soundcmd.cpp | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/engines/sci/sound/soundcmd.cpp b/engines/sci/sound/soundcmd.cpp index daba976f502c..9f3deca8ff52 100644 --- a/engines/sci/sound/soundcmd.cpp +++ b/engines/sci/sound/soundcmd.cpp @@ -534,8 +534,11 @@ reg_t SoundCommandParser::kDoSoundSendMidi(int argc, reg_t *argv, reg_t acc) { byte channel = argv[1].toUint16() & 0xf; byte midiCmd = argv[2].toUint16() & 0xff; - // TODO: first there is a 4-parameter variant of this call which needs to get reversed - // second the current code isn't 100% accurate, sierra sci does checks on the 4th parameter + // TODO: There is a 4 parameter variant of this call, + // used by at least lsl1vga. + // It lacks a midiCmd argument, but for this variant midiCmd defaults to + // 0xB0 (controller). If argv[2] is 0xFF, midiCmd is 0xE0 + // (pitchwheel). The exact parameters need to be investigated further. if (argc == 4) return acc;