Permalink
Browse files

SCI: Add some TODOs for better handling of wrong / missing resources

  • Loading branch information...
bluegr committed Dec 2, 2018
1 parent a8bae85 commit 8d4330a217200f646a7402c41ea1fd5d28667de9
Showing with 5 additions and 0 deletions.
  1. +3 −0 engines/sci/engine/message.cpp
  2. +2 −0 engines/sci/resource_audio.cpp
@@ -228,6 +228,9 @@ bool MessageState::getRecord(CursorStack &stack, bool recurse, MessageRecord &re
MessageTuple &t = stack.top();
// Fix known incorrect message tuples
// TODO: Add a more generic mechanism, like the one we have for
// script workarounds, for cases with incorrect sync resources,
// like the ones below.
if (g_sci->getGameId() == GID_QFG1VGA && stack.getModule() == 322 &&
t.noun == 14 && t.verb == 1 && t.cond == 19 && t.seq == 1) {
// Talking to Kaspar the shopkeeper - bug #3604944
@@ -476,6 +476,8 @@ int ResourceManager::readAudioMapSCI11(IntMapResourceSource *map) {
// FIXME: The sync36 resource seems to be two bytes too big in KQ6CD
// (bytes taken from the RAVE resource right after it)
if (syncSize > 0) {
// TODO: Add a mechanism to handle cases with missing resources like the ones below
//
// LB2CD is missing the sync resource for message 1885 1 6 30 2 but it's a duplicate
// of 1885 1 6 16 2 which does have a sync resource so use that for both. bug #9956
if (g_sci->getGameId() == GID_LAURABOW2 && map->_mapNumber == 1885 && n == 0x01061002) {

0 comments on commit 8d4330a

Please sign in to comment.