Permalink
Browse files

GUI: Disable Current View Selection Button in Save/Load Chooser.

Switching between List and Grid views causes a nasty redraw flicker.
This also occurs if you press the button for the current view type.

This patch does not fix the underlying refresh issue, but it does
disable the button for the current view type as pressing this is not
useful in any case.

This is a partial fix for bug Trac #10441.
  • Loading branch information...
digitall committed Oct 10, 2018
1 parent 88001f8 commit 9831f6ddd293202984d5d421f24d0078406ef9af
Showing with 8 additions and 2 deletions.
  1. +8 −2 gui/saveload-dialog.cpp
View
@@ -264,11 +264,17 @@ void SaveLoadChooserDialog::handleTickle() {
void SaveLoadChooserDialog::reflowLayout() {
#ifndef DISABLE_SAVELOADCHOOSER_GRID
addChooserButtons();
const SaveLoadChooserType currentType = getType();
const SaveLoadChooserType requestedType = getRequestedSaveLoadDialog(*_metaEngine);
addChooserButtons();
if (currentType == kSaveLoadDialogList) {
_listButton->setEnabled(false);
}
if (currentType == kSaveLoadDialogGrid) {
_gridButton->setEnabled(false);
}
// Change the dialog type if there is any need for it.
if (requestedType != currentType) {
setResult(kSwitchSaveLoadDialog);

0 comments on commit 9831f6d

Please sign in to comment.