hmmm, I see problem related to FixedRateVideoTrack class that can't get correct framerate from getDuration() timestamp because it's return only timestamp without real framerate information, because it's constructs timestamp(0, 264, 125) for 32 frame-length rlf-file with 66msec per frame (15 fps)
This is bacause:
Audio::Timestamp VideoDecoder::FixedRateVideoTrack::getFrameTime(uint frame) const { // frame = 32
Common::Rational frameRate = getFrameRate(); // frameRate = 1000/66 = 15.151515152
if (frameRate == frameRate.toInt()) // 15.151515152 != 15
return Audio::Timestamp(0, frame, frameRate.toInt()); //this will construct normal timestamp with real framerate, but not in this case!!
Common::Rational time = frameRate.getInverse() * frame; // and this converts it to
return Audio::Timestamp(0, time.getNumerator(), time.getDenominator()); // 264 frames and 125 as rate.
}
This comment has been minimized.
This is too much dirty
This comment has been minimized.
Why don't you make _frmDelay a Common::Rational instead so you don't truncate the data?
This comment has been minimized.
hmmm, I see problem related to FixedRateVideoTrack class that can't get correct framerate from getDuration() timestamp because it's return only timestamp without real framerate information, because it's constructs timestamp(0, 264, 125) for 32 frame-length rlf-file with 66msec per frame (15 fps)
This is bacause:
This comment has been minimized.
@Marisa-Chan Nice catch! I'll write up a fix.
EDIT: The fix is in bed5325