Skip to content

Commit

Permalink
TITANIC: Remove redundant static from CStarControlSub6
Browse files Browse the repository at this point in the history
It was only ever used as a temporary matrix in the constructor.
Given that, it was cleaner to simply declare it as a local variable.
  • Loading branch information
dreammaster committed Mar 27, 2017
1 parent 765ec88 commit a925264
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 18 deletions.
2 changes: 0 additions & 2 deletions engines/titanic/star_control/star_control.cpp
Expand Up @@ -43,13 +43,11 @@ END_MESSAGE_MAP()

CStarControl::CStarControl() : _enabled(false),
_starRect(20, 10, 620, 350) {
CStarControlSub6::init();
CStarControlSub12::init();
DMatrix::init();
}

CStarControl::~CStarControl() {
CStarControlSub6::deinit();
CStarControlSub12::deinit();
DMatrix::deinit();
}
Expand Down
11 changes: 0 additions & 11 deletions engines/titanic/star_control/star_control_sub6.cpp
Expand Up @@ -24,8 +24,6 @@

namespace Titanic {

CStarControlSub6 *CStarControlSub6::_static;

CStarControlSub6::CStarControlSub6() {
clear();
}
Expand Down Expand Up @@ -80,15 +78,6 @@ CStarControlSub6::CStarControlSub6(const CStarControlSub6 *s1, const CStarContro
+ s2->_vector._z;
}

void CStarControlSub6::init() {
_static = nullptr;
}

void CStarControlSub6::deinit() {
delete _static;
_static = nullptr;
}

void CStarControlSub6::identity() {
FMatrix::identity();
_vector.clear();
Expand Down
5 changes: 0 additions & 5 deletions engines/titanic/star_control/star_control_sub6.h
Expand Up @@ -28,11 +28,6 @@
namespace Titanic {

class CStarControlSub6 : public FMatrix {
private:
static CStarControlSub6 *_static;
public:
static void init();
static void deinit();
public:
FVector _vector;
public:
Expand Down

0 comments on commit a925264

Please sign in to comment.