Skip to content
Permalink
Browse files

TOOLS: configure options for all-unstable-engines

  • Loading branch information
rsn8887 committed Mar 9, 2017
1 parent 12bedb4 commit bd54615363ec96c8decf34cd039017b91c7c279e
Showing with 30 additions and 0 deletions.
  1. +30 −0 configure
@@ -626,6 +626,26 @@ engine_disable_all() {
done
}

# Enable *all unstable* engines
engine_enable_all_unstable() {
for engine in $_engines; do
engine_build_default=`get_engine_build_default $engine`
if test $engine_build_default = no ; then
engine_enable $engine
fi
done
}

# Disable *all unstable* engines
engine_disable_all_unstable() {
for engine in $_engines; do
engine_build_default=`get_engine_build_default $engine`
if test $engine_build_default = no ; then
engine_disable ${engine}
fi
done
}

# Enable the given engine
engine_enable() {
# Get the parameter
@@ -946,6 +966,10 @@ Game engines:
--enable-all-engines enable all engines, including those which are
broken or unsupported
--disable-all-engines disable all engines
--enable-all-unstable-engines
enable all engines which are broken or unsupported
--disable-all-unstable-engines
disable all engines which are broken or unsupported
--enable-engine=<engine name>[,<engine name>...] enable engine(s) listed
--disable-engine=<engine name>[,<engine name>...] disable engine(s) listed
--enable-engine-static=<engine name>[,<engine name>...]
@@ -1350,6 +1374,12 @@ for ac_option in $@; do
--disable-all-engines)
engine_disable_all
;;
--enable-all-unstable-engines)
engine_enable_all_unstable
;;
--disable-all-unstable-engines)
engine_disable_all_unstable
;;
--enable-engine=* | --enable-engines=*)
for engine_name in `echo $ac_option | cut -d '=' -f 2- | tr ',' '\n'`; do
engine_enable "${engine_name}"

7 comments on commit bd54615

@wjp

This comment has been minimized.

Copy link
Member

@wjp wjp replied Mar 9, 2017

I would appreciate it if you discussed changes like this beforehand.

@rsn8887

This comment has been minimized.

Copy link
Contributor Author

@rsn8887 rsn8887 replied Mar 9, 2017

Sorry will do next time. I thought it was a minor thing since it is completely optional.

@wjp

This comment has been minimized.

Copy link
Member

@wjp wjp replied Mar 9, 2017

I don't really see the point of this option, though. It seems the only use case is to override a previous --enable-all-engines option, in which case you just shouldn't have passed that option in the first place.

@criezy

This comment has been minimized.

Copy link
Member

@criezy criezy replied Mar 9, 2017

I don't really see the points of those options either.

On its own --disable-all-unstable-engines doesn't do anything, and using --enable-all-engines --disable-all-unstable-engines is the same as using no option at all. So I agree with wjp that in such a case we should not use --enable-all-engines in the first place. And similarly on its own --enable-all-unstable-engines is the same as --enable-all-engines. So the only setting I can see that is now easy and would have been difficult before is to disable all stable engines and enable the unstable ones (--disable-all-engines --enable-all-unstable-engines), but that doesn't seem like a terribly useful setting to me.

@rsn8887

This comment has been minimized.

Copy link
Contributor Author

@rsn8887 rsn8887 replied Mar 9, 2017

I definitely want to enable only the unstable engines sometimes, for example to build a separate scummVM with only unstable engines that could be distributed in addition to a scummVM with only the stable engines (if it runs out of memory)

@rsn8887

This comment has been minimized.

Copy link
Contributor Author

@rsn8887 rsn8887 replied Mar 9, 2017

Also it is good for testing to be able to only build with unstable engines. My main reason was to be able in the buildbot to selectively disable only the unstable engines, after the option --enable-all-engines.

But in general, I think it should be possible to select any combination of {stable, unstable} using combinations of the enable-all options

@sev-

This comment has been minimized.

Copy link
Member

@sev- sev- replied Mar 9, 2017

I definitely want to enable only the unstable engines sometimes

This is a no go. The purpose of having unstable engines is that they are not for the public use. On the buildbot we are enabling them solely for the compilation tests. Some of those do not even provide useable results, e.g. Chewy. Thus, when enabling those, you need to enable them one by one.

Since your port compiles well on the buildbot with all engines on, just doesn't run, I suggest to continue it doing so. You might consider not enabling all engines in the nightly builds, so those could be useable.

And yes, this commit should be reverted.

Please sign in to comment.
You can’t perform that action at this time.