New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHERLOCK: Disable cache for uncompressed resources #1092

Merged
merged 1 commit into from Dec 22, 2017

Conversation

Projects
None yet
4 participants
@AReim1982
Contributor

AReim1982 commented Dec 22, 2017

Sherlock Holmes - Case Of The Rose Tattoo:
Low memory devices (for example the WII) throws an "Out Of Memory" error during the intro and the gameplay. The reason is that all resources are cached in the memory. It improves the performance when resources are compressed. But the cache shouldn't be used for uncompressed resources.

@dreammaster

This comment has been minimized.

Show comment
Hide comment
@dreammaster

dreammaster Dec 22, 2017

Member

The change tested okay to me. There wasn't any excessive disk thrashing that would require the resources to be cached in any case. Just one thing.. to conform to our commit standards, could you modify the commit message to capitalize the word 'SHERLOCK'. Then I'll merge it in.

Member

dreammaster commented Dec 22, 2017

The change tested okay to me. There wasn't any excessive disk thrashing that would require the resources to be cached in any case. Just one thing.. to conform to our commit standards, could you modify the commit message to capitalize the word 'SHERLOCK'. Then I'll merge it in.

@AReim1982 AReim1982 changed the title from Sherlock: disable cache for uncompressed resources to SHERLOCK: disable cache for uncompressed resources Dec 22, 2017

@AReim1982

This comment has been minimized.

Show comment
Hide comment
@AReim1982

AReim1982 Dec 22, 2017

Contributor

done... ;-)

Contributor

AReim1982 commented Dec 22, 2017

done... ;-)

@AReim1982 AReim1982 closed this Dec 22, 2017

@AReim1982 AReim1982 reopened this Dec 22, 2017

@AReim1982 AReim1982 changed the title from SHERLOCK: disable cache for uncompressed resources to SHERLOCK: Disable cache for uncompressed resources Dec 22, 2017

@dreammaster dreammaster merged commit c8c804c into scummvm:master Dec 22, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Kroc

This comment has been minimized.

Show comment
Hide comment
@Kroc

Kroc Dec 22, 2017

I should test this on PSP because the game won't start and it could be related. Is there any way to get logs from PSP builds?

Kroc commented Dec 22, 2017

I should test this on PSP because the game won't start and it could be related. Is there any way to get logs from PSP builds?

@bonki

This comment has been minimized.

Show comment
Hide comment
@bonki

bonki May 5, 2018

Member

Reverted in commit afc48cf because it broke Scalpel (see https://bugs.scummvm.org/ticket/10510).

Member

bonki commented May 5, 2018

Reverted in commit afc48cf because it broke Scalpel (see https://bugs.scummvm.org/ticket/10510).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment