Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZVISION: Add workaround for ZGI bug #10605 #1236

Merged
merged 1 commit into from Jul 29, 2018

Conversation

@eriktorbjorn
Copy link
Member

commented Jun 30, 2018

This is one possible way of working around ZGI bug #10605. It was possible for the "Fire! Fire!" timer to get stuck if you brought up the inventory screen before it had timed out. (Unless you brought it up very quickly so that there was still more than 10 units left on the clock.)

I have a sneaking suspicion that there may be other timer-related script bugs, but I haven't looked for them. See the bug report for some further thoughts.

It's possible to get the "Fire! Fire!" timer stuck after setting
the the inquisitor doll on fire. This should work around that.
@dafioram

This comment has been minimized.

Copy link
Member

commented Jun 30, 2018

This workaround worked for me.

@criezy

This comment has been minimized.

Copy link
Member

commented Jul 3, 2018

The change looks fine to me.

@eriktorbjorn

This comment has been minimized.

Copy link
Member Author

commented Jul 9, 2018

I should mention that I haven't been able to get ZGI to run under Wine (I know it should be possible, but it didn't work for me), so I haven't been able to verify that it also happens in the original.

If it doesn't happen in the original, then it's probably a bug in how ScummVM handles ZVision's timers.

@dafioram

This comment has been minimized.

Copy link
Member

commented Jul 9, 2018

I have verified that this bug does happen in the original engine for CD 1.2.

My DVD version is from GOG and runs on ScummVM so I can't check the DVDs behavior, but I think it's safe to assume that it is the same.

@sev-

This comment has been minimized.

Copy link
Member

commented Jul 29, 2018

Thanks, merging

@sev- sev- merged commit f6a0e19 into scummvm:master Jul 29, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.