New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TINSEL: Add playTime to saved game and display it #1245

Merged
merged 1 commit into from Aug 3, 2018

Conversation

Projects
None yet
2 participants
@dafioram
Contributor

dafioram commented Jul 9, 2018

Also bumps the saved game format version to 3.

I changed the order of how the data is saved so that
the playtime could be read in without skipping as much data.

This is because querySaveMetaInfos only needs the metafields
where as saveload::DoRestore() needs more of the header.

A crash was happening when trying to delete a saved game from the
launcher. It is because the engine is not initalized. I assign a
dummy value to resolve the issue.

Loading saved games from previous versions works.

When an old version saved game is loaded it will start with
zero playtime.

Old saved games are shown as not having playtime data.

@dafioram

This comment has been minimized.

Show comment
Hide comment
@dafioram

dafioram Jul 9, 2018

Contributor

I have tested the save structure by starting a new game and playing through dw1. I also tested loading old ver2 saves both from the launcher and in game (both from a loaded ver2 and ver3 save). As well as saving a new save when loading from a version 2 save.

I did similar testing with dw2, but I didn't play much of dw2.

Contributor

dafioram commented Jul 9, 2018

I have tested the save structure by starting a new game and playing through dw1. I also tested loading old ver2 saves both from the launcher and in game (both from a loaded ver2 and ver3 save). As well as saving a new save when loading from a version 2 save.

I did similar testing with dw2, but I didn't play much of dw2.

TINSEL: Add playTime to saved game and display it
Also bumps the saved game format version to 3.

I changed the order of how the data is saved so that the playtime could
be read in without skipping as much data.

This is because querySaveMetaInfos only needs the metafields where as
saveload::DoRestore() needs more of the header.

A crash was happening when trying to delete a saved game from the launcher.
It is because the engine is not initalized. I assign a dummy value to
resolve the issue.

Loading saved games from previous versions works.

When an old version saved game is loaded it will start with zero playtime.

Old saved games are shown as not having playtime data.
@sev-

This comment has been minimized.

Show comment
Hide comment
@sev-

sev- Aug 3, 2018

Member

Good stuff.

Member

sev- commented Aug 3, 2018

Good stuff.

@sev- sev- merged commit f06cf65 into scummvm:master Aug 3, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dafioram

This comment has been minimized.

Show comment
Hide comment
@dafioram

dafioram Aug 3, 2018

Contributor

Even though this has been merged it would probably still be good for it to be glanced at by @dreammaster.

Contributor

dafioram commented Aug 3, 2018

Even though this has been merged it would probably still be good for it to be glanced at by @dreammaster.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment