New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VIDEO: Fix Theora playback when building with Tremor #1268

Merged
merged 1 commit into from Aug 3, 2018

Conversation

Projects
None yet
4 participants
@sev-

This comment has been minimized.

Show comment
Hide comment
@sev-

sev- Aug 3, 2018

Member

Thanks, obviously, nobody tried that before.

Member

sev- commented Aug 3, 2018

Thanks, obviously, nobody tried that before.

@sev- sev- merged commit 5cf3b75 into scummvm:master Aug 3, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ccawley2011 ccawley2011 deleted the ccawley2011:theora-tremor branch Aug 3, 2018

@bgK

This comment has been minimized.

Show comment
Hide comment
@bgK

bgK Aug 3, 2018

Member

Our dingux toolchain seems to be using the low memory branch of tremor (https://git.xiph.org/?p=tremor.git;a=tree;h=refs/heads/lowmem;hb=refs/heads/lowmem), that does not have all the features used by the theora decoder (http://buildbot.scummvm.org/builders/master-dingux/builds/32/steps/compile/logs/stdio).

Member

bgK commented Aug 3, 2018

Our dingux toolchain seems to be using the low memory branch of tremor (https://git.xiph.org/?p=tremor.git;a=tree;h=refs/heads/lowmem;hb=refs/heads/lowmem), that does not have all the features used by the theora decoder (http://buildbot.scummvm.org/builders/master-dingux/builds/32/steps/compile/logs/stdio).

@digitall

This comment has been minimized.

Show comment
Hide comment
@digitall

digitall Aug 6, 2018

Member

@bgK : Have committed scummvm/scummvm-sites@9a25fdd to try to restore Dingux nightly builds. Will see if this works.

Member

digitall commented Aug 6, 2018

@bgK : Have committed scummvm/scummvm-sites@9a25fdd to try to restore Dingux nightly builds. Will see if this works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment