Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUILD: Use C++14 / C++11 by default #1294

Closed
wants to merge 4 commits into from
Closed

Conversation

@ccawley2011
Copy link
Member

ccawley2011 commented Aug 16, 2018

Originally from PR #1128

csnover and others added 4 commits Dec 4, 2017
This detects and addresses a problem with the AmigaOS compiler that
prevents standard C++ versions from working correctly due to a
missing vsnprintf.
The blessed way to run the compiler is to use some custom GNU Make
file from PSPSDK, which we do not use, which sets the appropriate
linker flags. Running the compiler stand-alone just fails at link
time because crt0.o references libraries which are not included
by default.

The main compiler test was changed to not link
in 513cdb4, apparently because the
PS2SDK did the same thing, and now that we have more tests (some
of which do require linking since we test for unresolvable
symbols), it is really necessary to get the flags set up early.
@sev-
Copy link
Member

sev- commented Aug 18, 2018

This switches to C++14 compilation by default, which needs to be discussed with the porters on -devel first.

@bluegr bluegr changed the title BUILD: Add improved automatic detection of C++ standard version support BUILD: Use C++14 / C++11 by default Dec 25, 2018
@bluegr
Copy link
Member

bluegr commented Dec 25, 2018

Renaming for brevity

@lotharsm
Copy link
Member

lotharsm commented Apr 13, 2019

Any news on this?

@sev-
Copy link
Member

sev- commented May 3, 2020

So, in order to have a newer C++ standard enabled by default, so we could start relying on it, somebody needs to add in a separate file a series of tests for all the desired functionality, just calling is fine, and make a separate configure key for enabling it.

Then, at the time of release, we will ask all porters to try to compile it and report. This way we will understand any potential losses or complications.

In the meantime, closing this.

@sev- sev- closed this May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.