Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
MACOSX/IOS: Various updates from PR #1128 #1307
criezy left a comment
I am not confortable at this point with getting rid of the old macOS packaging code (commit 51e33cf), since this was still what I used for the last release, and whoever does the next one (possibly me) might still want to use it. The commit mentioned that in a controlled environment where you only have the static libraries having a separate static build target is not needed, which is true. But in most environment you will have some dynamic libraries and developers might want to generate a static build without having to use the Docker image that allows it. Commit 4dfa61e might mitigate this, but I would like more time to check and verify those changes.
And as noted in my review I would also like more time to verify the change to the link flags in 830edf3.
I have merged the uncontroversial commits manually.
I don't want to merge commit 80bc3ae as is, and as a result I cannot merge commits 2c44681 and d0169e7. However those commits contain some nice change, but I will need more time to try to extract them if possible. I made a note of that and I am closing this PR now.