New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRYO: EDEN: Move graphics into a separate class #1323

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@dafioram
Member

dafioram commented Sep 1, 2018

Eden game object now contains a graphics object with which to
delegate graphics operations and store states of the graphics.

Before all the graphics and eden code where together.

Much of the video playing is done in the graphics class
so I have moved a lot of the video state into there.

Some graphics related variables were moved out of eden and into
graphics, but many are still in eden.

Since they are still coupled there are lots of getters and setters.
For example both eden_graphics and eden share a handle to the same
video object.

I have made a few more things public than desirable.

I changed graphics to eden_graphics since it is specialized to eden
and not just cryo.

CRYO: EDEN: Move graphics into a separate class
Eden game object now contains a graphics object with which to
delegate graphics operations and store states of the graphics.

Much of the video playing is done in the graphics class
so I have moved a lot of the video state into there.

Some graphics related variables were moved out of eden and into
graphics, but many are still in eden.

Since they are still coupled there are lots of getters and setters.
For example both eden_graphics and eden share a handle to the same
video object.

I have made a few more things public than desirable.

I changed graphics to eden_graphics since it is specialized to eden
and not just cryo.

@dafioram dafioram requested a review from Strangerke Sep 1, 2018

@dafioram dafioram closed this Oct 5, 2018

@sev-

This comment has been minimized.

Show comment
Hide comment
@sev-

sev- Oct 5, 2018

Member

Why did you close it? The changes are fine, and they're worth merging.

Member

sev- commented Oct 5, 2018

Why did you close it? The changes are fine, and they're worth merging.

@dafioram

This comment has been minimized.

Show comment
Hide comment
@dafioram

dafioram Oct 5, 2018

Member

It's very possible that bugs have been introduced in this partial refactoring.

Member

dafioram commented Oct 5, 2018

It's very possible that bugs have been introduced in this partial refactoring.

@dafioram dafioram reopened this Oct 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment