New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MOHAWK: RIVEN: Don't allow GMM saving at the main menu #1325

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@dafioram
Member

dafioram commented Sep 2, 2018

Currently, the game can be saved as soon as the game has started
at the main menu.

This change prevents that and other times that the menu is opened.
The game can still be saved via the main menu once a game has
been started (not using the gmm).

GMM saving still works where it used to outside of the main menu.

MOHAWK: RIVEN: Don't allow GMM saving at the main menu
Currently, the game can be saved as soon as the game has started
at the main menu.

This change prevents that and other times that the menu is opened.
The game can still be saved via the main menu once a game has
been started (not using the gmm).

GMM saving still works where it used to outside of the main menu.

@dafioram dafioram requested a review from bgK Sep 2, 2018

@bgK

This comment has been minimized.

Show comment
Hide comment
@bgK

bgK Sep 2, 2018

Member

It's ok to prevent loading when the game is not started yet, but I'd prefer if saving from the GMM while the main menu is open still worked in other occasions. Also please notice the MohawkEngine_Riven::isGameStarted() method, you should be able to reuse it.

Member

bgK commented Sep 2, 2018

It's ok to prevent loading when the game is not started yet, but I'd prefer if saving from the GMM while the main menu is open still worked in other occasions. Also please notice the MohawkEngine_Riven::isGameStarted() method, you should be able to reuse it.

@dafioram

This comment has been minimized.

Show comment
Hide comment
@dafioram

dafioram Sep 2, 2018

Member

I don't think I can use the isGameStarted since it is always false at the main menu?

If you want the ability to gmm save while at the main menu we can keep that behavior.

Member

dafioram commented Sep 2, 2018

I don't think I can use the isGameStarted since it is always false at the main menu?

If you want the ability to gmm save while at the main menu we can keep that behavior.

@dafioram dafioram closed this Sep 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment