New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOS: Hide keyboard when rotating to landscape #1326

Merged
merged 1 commit into from Oct 18, 2018

Conversation

Projects
None yet
3 participants
@jlegeny
Contributor

jlegeny commented Sep 5, 2018

On iOS12 at least, the rotation did not force the keyboard to hide. This
fix will force it to be retracted in landscape and restored when
rotating back to the portrait position.

IOS: Hide keyboard when rotating to landscape
On iOS12 at least, the rotation did not force the keyboard to hide. This
fix will force it to be retracted in landscape and restored when
rotating back to the portrait position.
@sluicebox

This comment has been minimized.

Member

sluicebox commented Sep 12, 2018

I just tested this fix in iOS11 and it works; the keyboard now hides in landscape mode. Thanks!

@digitall

This comment has been minimized.

Member

digitall commented Oct 18, 2018

This PR has been open for more than a month, so should have been enough time for review.

Since several IOS users have reported testing this without issues, and it has been incorporated in two of the most recent IOS specific pull requests, I think it is worth merging this fix and then seeing what impact it has in terms of buildbot and other IOS users testing with the nightly builds.

Merging...

@digitall digitall merged commit b705262 into scummvm:master Oct 18, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jlegeny jlegeny deleted the jlegeny:ios-rotation-fix branch Oct 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment