Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-hide/show keyboard for non-iPad only (iPhone) + allow show/hide of keyboard using 4-finger swipes #1332

wants to merge 8 commits into from


None yet
2 participants
Copy link

commented Sep 13, 2018

An extension of this PR: #1326

For iPhone, the auto hide in landscape, auto show in portrait is pretty okay!

But I don't think there is a great need to autoshow/hide the keyboard for iPad - the iPad software keyboard has a hide button. So I fixed that.

Also if the user for whatever reason wants to show/hide the keyboard at will, he/she may do so using four-finger swipes up/down. Hopefully this doesn't clash with anything. I don't think there were any "four finger" gestures in the old scumm games...

Trying this out now myself for a while.

Jozef Legény and others added some commits Sep 5, 2018

Jozef Legény
IOS: Hide keyboard when rotating to landscape
On iOS12 at least, the rotation did not force the keyboard to hide. This
fix will force it to be retracted in landscape and restored when
rotating back to the portrait position.

This comment has been minimized.

Copy link

commented Oct 18, 2018

@jonnyijapan : Thanks for the code contribution. Have now merged PR #1326 so could you rebase your PR to remove this and the merge commit please? Also, could you modify the commit messages of the other commits to comply with ... "IOS: Added" etc.


This comment has been minimized.

Copy link
Contributor Author

commented Oct 20, 2018

@digitall Ok will fix.


This comment has been minimized.

Copy link
Contributor Author

commented Oct 20, 2018

Closing here, new PR at #1358

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.