New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-hide/show keyboard for non-iPad only (iPhone) + allow show/hide of keyboard using 4-finger swipes #1332

Open
wants to merge 8 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@jonnyijapan
Contributor

jonnyijapan commented Sep 13, 2018

An extension of this PR: #1326

For iPhone, the auto hide in landscape, auto show in portrait is pretty okay!

But I don't think there is a great need to autoshow/hide the keyboard for iPad - the iPad software keyboard has a hide button. So I fixed that.

Also if the user for whatever reason wants to show/hide the keyboard at will, he/she may do so using four-finger swipes up/down. Hopefully this doesn't clash with anything. I don't think there were any "four finger" gestures in the old scumm games...

Trying this out now myself for a while.

jlegeny and others added some commits Sep 5, 2018

IOS: Hide keyboard when rotating to landscape
On iOS12 at least, the rotation did not force the keyboard to hide. This
fix will force it to be retracted in landscape and restored when
rotating back to the portrait position.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment