New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LASTEXPRESS: added detection entry for gog release #1333

Merged
merged 1 commit into from Sep 14, 2018

Conversation

Projects
None yet
2 participants
@mgerhardy
Contributor

mgerhardy commented Sep 13, 2018

This adds a detection entry for the GOG release of LastExpress.

Questions:

  • What about AD_LISTEND - should it be used?
  • The CD* files are in a subdir named data/ - how to deal with that. Using data/CD1.HPF didn't work. I had to copy the files into the same dir as HD.HPF to be able to detect the game.

@mgerhardy mgerhardy force-pushed the mgerhardy:lastexpress-gog-release branch from 9fc673a to 152591e Sep 13, 2018

@digitall

This comment has been minimized.

Member

digitall commented Sep 14, 2018

@mgerhardy : Thanks for this patch. It looks reasonable as-is... at least comparing to the other detection entries.

To answer your two questions; Yes, AD_LISTEND should be used. It appears to have been omitted from the LASTEXPRESS engine detection entries. Since this maps to {0, NULL, 0, NULL} then assuming the detection structures are initialized to 0 which is also NULL, then you would probably get away with this normally... especially as the detection file list is a fixed size array of 14 ... so no pointer or bad access. Just glitches maybe in the detections.

However, I don't think that should block adding this, as that fix should be done to all entries in another commit. I will look at doing that after merging this.

Similarly, the data/CD* files issue should be fixed by adding a search path to the resource loading code found in engines/lastexpress/resource.{cpp, h} as per SearchMan or similar, but that is an issue for further work on the LASTEXPRESS engine. I will look at adding a FIXME to the detection entry to cope, but for now, you / users will have to move / link files instead.

@digitall digitall merged commit 3128c0b into scummvm:master Sep 14, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@digitall

This comment has been minimized.

Member

digitall commented Sep 14, 2018

Have fixed the missing AD_LISTEND markers in commit f0f02c4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment