New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHERLOCK: fixed missing member initialization #1339

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@mgerhardy
Contributor

mgerhardy commented Sep 14, 2018

No description provided.

@digitall

This comment has been minimized.

Show comment
Hide comment
@digitall

digitall Sep 14, 2018

Member

@mgerhardy : Thanks for the fix. However, this is not on the SHERLOCK engine, but the code changes are on the GOB engine... so the commit message is incorrect and will need changing.

I was also going to say that these did not comply with our http://wiki.scummvm.org/index.php/Code_Formatting_Conventions#Whitespaces ... However, I note that whitespace is allowed there for readability and your patch is formatted similar to surrounding code, so I am wrong there.

Will cherry pick, amend message and commit. Thanks again for this fix.

Member

digitall commented Sep 14, 2018

@mgerhardy : Thanks for the fix. However, this is not on the SHERLOCK engine, but the code changes are on the GOB engine... so the commit message is incorrect and will need changing.

I was also going to say that these did not comply with our http://wiki.scummvm.org/index.php/Code_Formatting_Conventions#Whitespaces ... However, I note that whitespace is allowed there for readability and your patch is formatted similar to surrounding code, so I am wrong there.

Will cherry pick, amend message and commit. Thanks again for this fix.

@digitall

This comment has been minimized.

Show comment
Hide comment
@digitall

digitall Sep 14, 2018

Member

Cherry picked and amended as 32c8ea0. Closing

Member

digitall commented Sep 14, 2018

Cherry picked and amended as 32c8ea0. Closing

@digitall digitall closed this Sep 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment