New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ANDROID: Implement clipboard support #1351

Merged
merged 1 commit into from Oct 4, 2018

Conversation

Projects
None yet
3 participants
@ccawley2011
Contributor

ccawley2011 commented Oct 4, 2018

This uses the older android.text.ClipboardManager API rather than the newer android.content.ClipboardManager in order to maintain compatibility with older Android versions.

@digitall

This comment has been minimized.

Show comment
Hide comment
@digitall

digitall Oct 4, 2018

Member

@ccawley2011 : Thanks for implementing this. Have taken a look over the code and looks fine to me. It should be fine to merge and see what (if any) issues that Buildbot throws up.

One question first though: What is the advantage / utility of implementing this? I know that it implements Clipboard Cut and Paste support and that is fine, but just trying to work out where this is used? In the "Edit Game" configuration for Launcher or is this one of the games such as AGI?

Member

digitall commented Oct 4, 2018

@ccawley2011 : Thanks for implementing this. Have taken a look over the code and looks fine to me. It should be fine to merge and see what (if any) issues that Buildbot throws up.

One question first though: What is the advantage / utility of implementing this? I know that it implements Clipboard Cut and Paste support and that is fine, but just trying to work out where this is used? In the "Edit Game" configuration for Launcher or is this one of the games such as AGI?

@criezy

This comment has been minimized.

Show comment
Hide comment
@criezy

criezy Oct 4, 2018

Member

@digitall Paste from clipboard was added for the cloud connection wizard. Copy to clipboard was added for the GUI dialog to report unknown game variants (so that the message could then be pasted in a bug report). It is also available in the debug console. And both can be used in the EditableWidget (for example the search field in the launcher, or indeed in the edit game dialog). I don't think it is used anywhere else yet.

Member

criezy commented Oct 4, 2018

@digitall Paste from clipboard was added for the cloud connection wizard. Copy to clipboard was added for the GUI dialog to report unknown game variants (so that the message could then be pasted in a bug report). It is also available in the debug console. And both can be used in the EditableWidget (for example the search field in the launcher, or indeed in the edit game dialog). I don't think it is used anywhere else yet.

@digitall

This comment has been minimized.

Show comment
Hide comment
@digitall

digitall Oct 4, 2018

Member

@criezy Thanks... That sounds more than sufficient and the ability to cut from the debug console in itself would be very useful. Overall, this looks fine, so am going to merge as-is and see what the buildbot makes of it.

Member

digitall commented Oct 4, 2018

@criezy Thanks... That sounds more than sufficient and the ability to cut from the debug console in itself would be very useful. Overall, this looks fine, so am going to merge as-is and see what the buildbot makes of it.

@digitall digitall merged commit 539c333 into scummvm:master Oct 4, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ccawley2011 ccawley2011 deleted the ccawley2011:android-clipboard branch Oct 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment