New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KYRA: Fix Urbish Mines Lobster Monster Crash in LOL. #1352

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
1 participant
@digitall
Member

digitall commented Oct 8, 2018

This occurs because of an out of buffer access when trying to play the monster sound effect.

This is from bug Trac #10665.

While this code change is restricted to Kyra's LOL code and thus only that game, and the fix does work to prevent the out of range access, it is not clear that this is the correct solution and will not stop other sound effects from playing. Also, it removes the sound effect from this monster, rather than correcting it to the correct effect... This could do with amendment by someone familar with the KYRA / LOL engine to see if there is a better solution, but if not, then merging this at least prevents LOL from crashing.

@digitall digitall requested a review from athrxx Oct 8, 2018

KYRA: Fix Urbish Mines Lobster Monster Crash in LOL.
This occurs because of an out of buffer access when trying to play the
monster sound effect.

This is bug Trac #10665.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment