New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POSIX: Set the default screenshots path to the XDG Pictures directory #1404

Merged
merged 1 commit into from Dec 2, 2018

Conversation

Projects
None yet
3 participants
@bgK
Member

bgK commented Nov 18, 2018

The screenshots are written to $XDG_PICTURES_DIR/ScummVM Screenshots as defined in the XDG user directories specification (https://www.freedesktop.org/wiki/Software/xdg-user-dirs/).

With this change the screenshots are saved to a user writable path by default on Linux when ScummVM is installed through a package manager.

@lotharsm

This comment has been minimized.

Member

lotharsm commented Nov 18, 2018

Sound like a good change to me.

Does that mean that currently saving screenshots is broken on Linux when scummvm is installed through a package manager?

@bgK

This comment has been minimized.

Member

bgK commented Nov 18, 2018

Does that mean that currently saving screenshots is broken on Linux when scummvm is installed through a package manager?

By default, the screenshot path was the working directory. When running ScummVM from the .desktop entry then the working directory is likely the home directory which would have worked. When launching from a shell, it depends whether the shell's current directory is writable.

@criezy

This comment has been minimized.

Member

criezy commented Nov 25, 2018

I think it indeed makes sense to change the default screenshots directory to the XDG_PICTURES_DIR on Linux/Unix.

@bgK bgK force-pushed the bgK:xdg-screenshots branch from e66bef9 to 21e49d1 Dec 2, 2018

@bgK bgK merged commit add9a0b into scummvm:master Dec 2, 2018

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment