New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCI: Fix SQ5 drive bay pathfinding, bug #7155 #1428

Merged
merged 1 commit into from Dec 2, 2018

Conversation

Projects
None yet
3 participants
@sluicebox
Contributor

sluicebox commented Nov 30, 2018

Works around a pathfinding algorithm edge case

SCI: Fix SQ5 drive bay pathfinding, bug #7155
Works around a pathfinding algorithm edge case

@digitall digitall requested review from bluegr and m-kiewitz Nov 30, 2018

@m-kiewitz

This comment has been minimized.

Contributor

m-kiewitz commented Nov 30, 2018

I don't really like patching this out, because the actual problem is the different pathfinding algo (as you have already written as well).

That code needs to be rewritten. More see bug report.

@bluegr

This comment has been minimized.

Member

bluegr commented Dec 1, 2018

Please add a comment that this script patch is a workaround. We can merge it for now, and remove it, together with other similar script patches, once we have a pathfinding algorithm that is 100% faithful to what the original SSCI did

@bluegr

This comment has been minimized.

Member

bluegr commented Dec 2, 2018

Update: I'll merge this together with the other pathfinding related pull requests, and mark these and any other pathfinding related script patches we already have as workarounds

@bluegr bluegr merged commit 58653c7 into scummvm:master Dec 2, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment