Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIN32: Fix missing export errors in Windows 98 #1430

Merged
merged 1 commit into from Dec 13, 2018

Conversation

Projects
None yet
4 participants
@SupSuper
Copy link
Contributor

SupSuper commented Dec 1, 2018

Fixes bug #10613 by replacing API calls not available in Windows 98 with older equivalents.

You still need to compile with SDL 1.2 yourself, but otherwise it works: https://i.imgur.com/MEhve8U.png

Show resolved Hide resolved backends/platform/sdl/win32/win32.cpp Outdated
Show resolved Hide resolved backends/platform/sdl/win32/win32.cpp
WIN32: Restore Windows 98 compatibility (bug #10613)
Replace calls to GetUserDefaultUILanguage and SHGetFolderPath which aren't supported in older Windows.

@SupSuper SupSuper force-pushed the SupSuper:win98 branch from 7dde325 to cfff21c Dec 11, 2018

@bluegr

bluegr approved these changes Dec 12, 2018

@digitall

This comment has been minimized.

Copy link
Member

digitall commented Dec 13, 2018

Since this should be good and @bluegr has now approved, merging this so that buildbot can check it...
@SupSuper : Thanks for looking at this.

@digitall digitall merged commit c2d5b35 into scummvm:master Dec 13, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@SupSuper SupSuper deleted the SupSuper:win98 branch Dec 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.