New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCI32: Fix QFG4 third tarot reading #1434

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
1 participant
@Vhati
Contributor

Vhati commented Dec 4, 2018

Fixes incorrect cards and placement

#10822

// The fortune teller's third reading places the "Two of Cups" across another
// card, off-center. That View (1023) is cropped (130x64). All other horizontal
// cards (130x86, 130x87) are padded at the bottom with transparent pixels.
//
// We optimize the method that creates and places cards, then specifically give
// this card a fudged y position. Our subroutine reduces the size of cases in a
// switch. We could rewrite all its cases, but just rewriting case 4 and 5 is
// enough.

#10823

// The fortune teller's third reading displays a right-turned "The Devil" card,
// but Magda says it is "Death".
//
// We change the card to a right-turned "Death".

#10824

// The fortune teller's third reading has the wrong card at the center. The 3rd
// and 4th reading are about different people, yet both have "Queen of Cups".
//
// The 1st reading establishes "Queen of Cups" as: a woman of wisdom and love,
// kind, generous, and virtuous. This fits the 4th reading: she uses her power
// joyfully, giving gracefully and lovingly to others.
//
// The 1st reading establishes "Queen of Swords" as: a deceiver or deceived,
// having suffered through terrible hardship, she faces her sorrows bravely,
// but with deep loneliness. This fits the 3rd reading better: some cruel event
// shaped her life... ambition, self-deception, and she is falling in love.
//
// We change the 3rd reading's center card to "Queen of Swords".

To test any reading...

  • Create a new character. Any kind.
  • Set plot flags for having seen previous readings.
    • Reading 1.
      • Just teleport.
    • Reading 2 (297).
      • vv g 518 64
    • Reading 3 (297, 298).
      • vv g 518 96
    • Reading 4 (297, 298, 299).
      • vv g 518 112
    • Reading 5 (297, 298, 299, 300).
      • vv g 518 120
  • Teleport into the tarot room.
    • room 475

For anyone interested in seeing higher-res cards...

Video: YouTube - Spoiler of the "Russian Tarot of St. Petersburg" deck (illus. Yury Shakov)

  • 0:31 Death
  • 0:34 The Devil
  • 0:46 Queen of Swords
  • 1:14 Queen of Cups
  • 1:25 Two of Cups
SCI32: Fix QFG4 third tarot reading
Fixes incorrect cards and placement, bugs #10822, #10823, #10824

@digitall digitall requested review from bluegr and m-kiewitz Dec 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment