Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
SCI32: Fix QFG4 tarot readings #1434
Fixes incorrect cards and placement in the third and fifth readings.
To test any reading...
For anyone interested in seeing higher-res cards...
Video: YouTube - Spoiler of the "Russian Tarot of St. Petersburg" deck (illus. Yury Shakov)
This is what sThirdReading looks like. It's basically a cutscene, where the player clicks to deal the next card and hear Magda's interpretation.
script 745 - sThirdReading::changeState()
local is the desired view for the card.
localproc_1cfb() selects HAND on g69_mainIconBar and calls g80_User::canInput(1), allowing the player to click the deck for another card.
script 475 - sShowCard::changeState()
5 times, most recently
Dec 17, 2018
While I caught up with master, I'd trimmed some bytes switching call offsets from UINT16 to single-byte. Waste bytes' disassembly happened to align without the need for an erasure line.
Forgot to adjust jumps and branches afterward. Should be working again now.
Nice work! This is quite a long list of bugs for the card readings, and your time spent on these is much appreciated! :)
Bug #10823 is obviously wrong, the voice describes a different card.
Bug #10824 is quite obscure. After reading through all the transcripts as you wrote them in the bug, it's quite apparent that the central card is wrong in the third reading.
Patching these (especially #10822) was hard. Kudos for your work!