New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCI32: Fix QFG4 obscured ropes when rescuing Igor #1436

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
1 participant
@Vhati
Contributor

Vhati commented Dec 5, 2018

Fixes a missing graphics update after priority is changed, bug #10751

// In the graveyard rescuing Igor, ropes are briefly obscured by crypt pillars
// in the background Pic. The Pic assigns a priority to the pillars for depth.
// Ropes are initialized without priority. Then there's a setPri() call.
//
// The floppy edition's Actor::doit() readily calls UpdateScreenItem(). Thus it
// promptly responds to the new priority, bringing the ropes to the front.
//
// The CD edition changed Actor to require a bit flag on the "signal" property
// before it would call UpdateScreenItem(). So the CD edition graphics don't
// update until much later, when the ropes begin an animation.
//
// We patch the heap for script 500 (the graveyard) to give rope1 and rope2
// that "signal" bit as soon as they're created.

@Vhati Vhati changed the title from SCI32: Fix obscured ropes when rescuing Igor to SCI32: Fix QFG4 obscured ropes when rescuing Igor Dec 5, 2018

SCI32: Fix QFG4 obscured ropes when rescuing Igor
Fixes a missing graphics update after priority is changed, bug #10751

@Vhati Vhati force-pushed the Vhati:qfg4_graveyard_rope branch from cfe7fc5 to 5919ee8 Dec 5, 2018

@digitall digitall requested review from bluegr and m-kiewitz Dec 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment