New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCI32: Fix QFG4 extraneous door sound in castle #1438

Merged
merged 1 commit into from Dec 9, 2018

Conversation

Projects
None yet
2 participants
@Vhati
Contributor

Vhati commented Dec 6, 2018

Fixes a second door sound when entering certain rooms, bug #10827

// Rooms 622 and 623 play an extra door sound when entering. They both
// delegate to script 645. It schedules sEnter, which indeed has an extra
// sound. The CD edition removed the line. We remove it, too.
//
// Applies to at least: English floppy, German floppy

To test, teleport to either room.

SCI32: Fix QFG4 extraneous door sound in castle
Fixes a second door sound when entering certain rooms, bug #10827

@digitall digitall requested review from bluegr and m-kiewitz Dec 6, 2018

@bluegr

This comment has been minimized.

Member

bluegr commented Dec 9, 2018

Thanks for your work! Merging

@bluegr bluegr merged commit 7bfc503 into scummvm:master Dec 9, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment