Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI: Allow opening the Mass Add dialog on platforms without a physical SHIFT key #1726

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@ccawley2011
Copy link
Member

commented Jul 1, 2019

No description provided.

@criezy

This comment has been minimized.

Copy link
Member

commented Jul 1, 2019

So if I read that correctly, in the MobileLauncherDialog it asks the user if he wants to do a scan, and does either a add (on No) or mass-add (on Yes).

This is actually slightly related to https://bugs.scummvm.org/ticket/7715 as if we were to implement the suggestion there we would not need a separate dialog for mobile and desktop ports.

@bgK

This comment has been minimized.

Copy link
Member

commented Jul 1, 2019

I agree with criezy the discoverability of mass add is pretty poor even on desktop platforms. IMO it would be better to improve it instead of adding a special case for mobile devices.

Regarding the changes in this PR I think it would be better to add some kind of option to choose the add button behavior rather than having a platform specific subclass. Platform specific subclasses/checks/... are harder to test and thus make the code hard to change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.