Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCI: Disable SQ4 timepod code for missing room #1728

Merged
merged 1 commit into from Jul 1, 2019

Conversation

Projects
None yet
3 participants
@sluicebox
Copy link
Member

commented Jul 1, 2019

This disables a timepod code that crashes the CD version because it's for a room that was removed from the game.

Normally this wouldn't be necessary, since no one will accidentally enter the eighteen digits, but the NRS version of SQ4 recreates this room and so the code appears on easter egg sites. People aren't reading the fine print about fan patches and think it's a regular easter egg code. Recently a video appeared on youtube of people attempting it, crashing in ScummVM as they would have in the original, and loudly blaming ScummVM.

Now that I see how easy it is to selectively enable patches by resource, which I was way wrong about, I'm doing that here. A fan version of this room's script already exists, and I love it, so if you have that as patch files then it will still work.

https://spacequest.fandom.com/wiki/Room_Removed_For_Legal_Reasons

@bluegr

This comment has been minimized.

Copy link
Member

commented Jul 1, 2019

Nice! Thanks for working on this quite obscure easter egg. Merging

@bluegr bluegr merged commit d8efb64 into scummvm:master Jul 1, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@m-kiewitz

This comment has been minimized.

Copy link
Contributor

commented Jul 3, 2019

a video appeared on youtube of people attempting it, crashing in ScummVM as they would have in the original, and loudly blaming ScummVM.

Link please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.