Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLK: Fix off-by-one memory read #1736

Merged
merged 1 commit into from Jul 7, 2019

Conversation

Projects
None yet
2 participants
@lephilousophe
Copy link
Member

commented Jul 7, 2019

I think this part of code is erroneous as it shouldn't check the previous item on the first iteration of the loop.
Moreover, this code seems to raise an internal compiler error of OpenPandora build. I hope my rewrite will fix it as well.

GLK: Fix off-by-one memory read
The for loop shouldn't check previous entity on the first iteration

@lephilousophe lephilousophe requested a review from dreammaster Jul 7, 2019

@dreammaster

This comment has been minimized.

Copy link
Member

commented Jul 7, 2019

Good catch on that. Fingers crossed it helps openpandora :)

@dreammaster dreammaster merged commit 1c87f42 into scummvm:master Jul 7, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@lephilousophe lephilousophe deleted the lephilousophe:fix-off-by-one branch Jul 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.