Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMMON: Support text wrapping with even width line segments #1762

Merged
merged 2 commits into from Aug 1, 2019

Conversation

@antoniou79
Copy link
Contributor

commented Jul 21, 2019

The new arguments are optional. The lines segments will be close to the same width.

The algorithm is similar to the one we had for Blade Runner but not exactly the same, since that one would wrap a line at a white space after the theoretical split point (quotient of full line text width divided by target lines number)

@antoniou79 antoniou79 requested review from sev- and peterkohaut and removed request for peterkohaut Jul 21, 2019

@bluegr

This comment has been minimized.

Copy link
Member

commented Jul 24, 2019

Looks good, well done! +1 from me

@peterkohaut
Copy link
Contributor

left a comment

lgtm

@bluegr

bluegr approved these changes Jul 29, 2019

@@ -175,8 +175,8 @@ class Font {
* @param initWidth the starting width of the first line, for partially filled lines (optional)
* @return the maximal width of any of the lines added to lines

This comment has been minimized.

Copy link
@sev-

sev- Jul 31, 2019

Member

Could you please describe the new parameters here?

@sev-

This comment has been minimized.

Copy link
Member

commented Jul 31, 2019

Looks great, just lacks a small piece of documentation.

antoniou79 added some commits Jul 21, 2019

COMMON: Support text wrapping with even width line segments
The new arguments are optional. The lines segments will be close to the same width.

The algorithm is similar to the one we had for Blade Runner but not exactly the same, since that one would wrap a line at a white space after the theoretical split point (quotient of full line text width divided by target lines number)

@antoniou79 antoniou79 force-pushed the antoniou79:evenWidthTextWrapSupport branch from 038a17d to 8df78ff Jul 31, 2019

@antoniou79 antoniou79 requested a review from sev- Aug 1, 2019

@sev-

This comment has been minimized.

Copy link
Member

commented Aug 1, 2019

Great! merging

@sev- sev- merged commit 4630895 into scummvm:master Aug 1, 2019

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.