Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
GUI: Minor fixes (scrollbars, tooltips, tabs, EditText) #1785
I've been making a custom theme based on Modern Remastered these couple of days (I call it Midnight theme). While I was at it, I locally fixed some things in GUI. Well, some changes are not really fixes, but edits that I thought look better.
These are not changes for my theme only, but sometimes they are better illustrated with my theme (scrollbars, for example). Below are pics comparing what was before the fixes and after these in both my theme and Modern Remastered (click to view in full size).
(illustrated in Midnight theme only, because Modern Remastered does not have any background or borders in scrollbar buttons, so you cannot see the overlapping)
(unfortunately, I couldn't resize scrollbar to have the same height as container for my Midnight theme, because then in Modern Remastered it overlap tabs not 1px, but 2px. As a result, we can see these "double borders" in Midnight)
(we can see that "tab" drawstep behaves strangely, and draws 2 more pixels where ScrollContainerWidget's area already begins; using "square" drawstep in Midnight theme solves that and looks more tidy)
And a long pic for lowres:
So, 15ee60f and 7dda053 are actual fixes (cropped scrollbar, TabWidget typos) and 95b8c99 with be1e8ae are just my edits that look prettier (vertical aligned text in EditText, 2px margin in tooltip, repositioned scrollbar).
P.S. Midnight theme is available on my site
criezy left a comment
@criezy , about that content overlapping: I guess this could/should be fixed by adding more right padding in the layout. That's a workaround, but if this glitch happens because of overlapping, I think the easiest way to fix it is just make things not overlap.