Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BACKENDS: Rename and simplify AbstractFSNode::create() #1788

Merged
merged 2 commits into from Aug 6, 2019

Conversation

@ccawley2011
Copy link
Member

commented Aug 4, 2019

This PR includes only the changes from PR #1727 related to AbstractFSNode. Merging this PR should allow implementations of createDirectory() to be worked on independently of PR #1727.

@bluegr

This comment has been minimized.

Copy link
Member

commented Aug 4, 2019

So, if I understand this correctly, this PR lacks the implementation for createDirectoryRecursive() and the PSP implementation, right?

Could you please open another pull request with the rest of the changes? I assume that the other pull request will show merge conflicts once this is merged

@bluegr

This comment has been minimized.

Copy link
Member

commented Aug 6, 2019

This is quite a straightforward change. I’m merging it, and we can deal with the conflicts in PR #1727 afterwards, so that porters can work on createDirectory() implementations.

Thanks for your work!

@bluegr bluegr merged commit db445bf into scummvm:master Aug 6, 2019

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ccawley2011 ccawley2011 deleted the ccawley2011:createDirectory-small branch Aug 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.