BACKENDS: Rename and simplify AbstractFSNode::create() #1788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So, if I understand this correctly, this PR lacks the implementation for createDirectoryRecursive() and the PSP implementation, right? Could you please open another pull request with the rest of the changes? I assume that the other pull request will show merge conflicts once this is merged |
|
This is quite a straightforward change. I’m merging it, and we can deal with the conflicts in PR #1727 afterwards, so that porters can work on createDirectory() implementations. Thanks for your work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes only the changes from PR #1727 related to AbstractFSNode. Merging this PR should allow implementations of
createDirectory()to be worked on independently of PR #1727.