Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDL: Simplify implementation of createLogFile() #1789

Merged
merged 1 commit into from Aug 5, 2019

Conversation

@ccawley2011
Copy link
Member

commented Aug 4, 2019

No description provided.

@criezy

criezy approved these changes Aug 4, 2019

Copy link
Member

left a comment

Nice.

@ccawley2011 ccawley2011 force-pushed the ccawley2011:createLogFile branch from 33bf040 to c09a6b2 Aug 4, 2019

@bluegr

This comment has been minimized.

Copy link
Member

commented Aug 5, 2019

Great work!

@bluegr

bluegr approved these changes Aug 5, 2019

@bluegr

This comment has been minimized.

Copy link
Member

commented Aug 5, 2019

This is quite a straightforward and good change. Many thanks for cleaning up this code! Merging

@bluegr bluegr merged commit 8b8fb6d into scummvm:master Aug 5, 2019

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.