Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WAGE: Don't require the data fork for the external sound file #1797

Merged
merged 1 commit into from Aug 11, 2019

Conversation

@ccawley2011
Copy link
Member

commented Aug 10, 2019

No description provided.

@bluegr

This comment has been minimized.

Copy link
Member

commented Aug 11, 2019

Nice work! Merging

@bluegr bluegr merged commit d8dc31a into scummvm:master Aug 11, 2019

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ccawley2011 ccawley2011 deleted the ccawley2011:wage-sounds branch Aug 11, 2019

@sev-

This comment has been minimized.

Copy link
Member

commented Aug 11, 2019

I apologise for the intrusion, but what is the purpose of this patch? And why it was introduced in the first place?

@bluegr, what makes 'nice' a patch without any description?

@ccawley2011

This comment has been minimized.

Copy link
Member Author

commented Aug 11, 2019

@sev-: When unpacking a StuffIt archive using The UnArchiver, it will only create the resource fork if the data fork is empty. Thus, the WAGE engine won't load the external sound file because the data fork doesn't exist, even though it only uses the resource fork.

@sev-

This comment has been minimized.

Copy link
Member

commented Aug 12, 2019

Ok, thanks for the explanation. Now it is clear. However, I need to check that it does work with my setup. I do not use UnArchiver, and most probably we will have to support both variants.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.