Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCI32: Fix Mirrored Pic Drawing #1798

Merged
merged 1 commit into from Aug 11, 2019

Conversation

@sluicebox
Copy link
Member

commented Aug 11, 2019

This fixes an off by one error in our SCI32 mirrored pic drawing. This can be seen in any room with style property bit $0400. The pic is drawn one coordinate to the left of where it should be and leaves a line of garbage on the right or left edge of the screen, depending on the compiler.

This fixes at least QFG4, which has many mirrored rooms such as 551, and LSL6 Hi Res rooms 305, 640, and 680.

Confirmed in disassembly. Fixes bug #10748

SCI32: Fix Mirrored Pic Drawing
Fixes bug #10748
@bluegr

This comment has been minimized.

Copy link
Member

commented Aug 11, 2019

Nice catch, thanks! Merging

@bluegr bluegr merged commit 6884349 into scummvm:master Aug 11, 2019

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.