Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCI: Fix SQ4CD hintbook text layout #1801

Merged
merged 1 commit into from Aug 12, 2019

Conversation

@sluicebox
Copy link
Member

commented Aug 12, 2019

This fixes SQ4CD's hintbook layout, which is currently drawn incorrectly, due to parsing message text as if it were escaped hex codes. SQ4CD's interpreter doesn't have this feature. Converting this text to hex codes, and then applying the buggy hex conversion that appeared in later interpreters, causes newlines to appear and the text sizing to be off.,

Fixes #11070

@bluegr

This comment has been minimized.

Copy link
Member

commented Aug 12, 2019

Nice! Merging

@bluegr bluegr merged commit 0069281 into scummvm:master Aug 12, 2019

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.