Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VITA: Use activeArea rectangle also on Vita #1803

Merged
merged 1 commit into from Aug 14, 2019

Conversation

@rsn8887
Copy link
Contributor

commented Aug 13, 2019

This PR changes the Vita graphics manager so that the AR correction and game screen texture scaling is done similarly to other surfaceSDL platforms. However, several issues came to light concerning aspect ratio correction now that Vita does it similarly as other platforms:

  • AR doesn't work at all in Dreamweb when using 2x or 1x rendering. I observe this also on latest MacOS nightly. It works using OpenGL on MacOS though.

  • AR works just fine in the main menu, and seems to work fine in Monkey Island on first glance. On closer inspection, enabling AR causes dirty rect gfx glitches in Monkey Island when the mouse is moved across the screen (warped) with the analog stick or touch input. When the cursor is close to the top edge of the screen, also significant slowdown occurs, not just flickering of rects.

  • AR Is done via software scaling instead of adapting activeArea dimensions. I suspect a historical reason for this but it seems unnecessary and also slower.

These problems only appear when the aspect ratio correction tickbox is on. Otherwise everything seems to work fine.

Thanks to @ccawley2011 for pointing me towards this.

@rsn8887 rsn8887 changed the title Use activeArea rectangle also on Vita (WIP do not merge yet) VITA: Use activeArea rectangle also on Vita (WIP do not merge yet) Aug 13, 2019

@rsn8887 rsn8887 force-pushed the rsn8887:psp2activeArea branch from 8bae9f0 to 9732f87 Aug 14, 2019

@rsn8887

This comment has been minimized.

Copy link
Contributor Author

commented Aug 14, 2019

The new stretch mode "Fit to window (4:3)" in combination with unticking the "aspect ratio correction" tickmark gives a hardware aspect ratio that works similar to how Vita used to work. So with this PR we get all the choices, and it removes a bunch of ugly hacks to scale the screen.

@rsn8887 rsn8887 changed the title VITA: Use activeArea rectangle also on Vita (WIP do not merge yet) VITA: Use activeArea rectangle also on Vita Aug 14, 2019

@rsn8887 rsn8887 force-pushed the rsn8887:psp2activeArea branch from 9732f87 to f961b2d Aug 14, 2019

@rsn8887 rsn8887 merged commit afd3607 into scummvm:master Aug 14, 2019

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.