Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BACKENDS: add Fit to window (4:3) stretch mode to SDL2 backend #1806

Merged
merged 1 commit into from Aug 14, 2019

Conversation

@rsn8887
Copy link
Contributor

commented Aug 13, 2019

This simple PR adds a fourth stretch mode to the SDL2 backend, called "Fit to window (4:3)". It fits the screen to the window similar to the existing "Fit to window" stretch mode, but enforces a 4:3 aspect ratio.

Using this stretch mode and unticking the "aspect ratio correction" does hardware aspect ratio correction on all SDL2 platforms, making use of the SDL2 scaler. This is similar to what has always been done on Vita.

This method is faster and often better looking than the software aspect ratio correction that can be enabled with the checkbox.

One downside compared to checking the "aspect ratio correction" tick mark is that the menu and user interface will also be hardware-scaled just like the game screen. This means the menu font, mouse pointer and buttons will look slightly stretched. But that is just the same as with all other stretch modes.

@rsn8887 rsn8887 force-pushed the rsn8887:stretchmode branch 2 times, most recently from f1b7e9b to 55c7f3e Aug 13, 2019

@rsn8887 rsn8887 changed the title BACKENDS: add Fit 4:3 stretch mode to SDL2 backend BACKENDS: add Fit to window (4:3) stretch mode to SDL2 backend Aug 13, 2019

@rsn8887 rsn8887 force-pushed the rsn8887:stretchmode branch from 55c7f3e to 04b7333 Aug 13, 2019

@rsn8887 rsn8887 force-pushed the rsn8887:stretchmode branch from 04b7333 to d2a5edf Aug 14, 2019

@rsn8887 rsn8887 merged commit 5b32f37 into scummvm:master Aug 14, 2019

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.