Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMMON: fixed reading ini files which have not value for key #1814

merged 1 commit into from Aug 19, 2019


Copy link

commented Aug 19, 2019

Ini files with structure like this can't be read. This pull request fixes this.
Key1 = Value1
Key4 = Value2

kv.value = String(p + 1);
if (!p) {
warning("Config file buggy: Junk found in line line %d: '%s'", lineno, t);
kv.key = String(t);

This comment has been minimized.

Copy link

bluegr Aug 19, 2019


kv is reused for each line read, so its value member should be reset here

@whiterandrek whiterandrek force-pushed the whiterandrek:ini2 branch from c0db208 to 363d4d7 Aug 19, 2019


This comment has been minimized.

Copy link

commented Aug 19, 2019

Thanks :) merging

@bluegr bluegr merged commit f52a96e into scummvm:master Aug 19, 2019

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
continuous-integration/travis-ci/pr The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
2 participants
You can’t perform that action at this time.